Visualise C++20 chrono additions#1773
Merged
AnjuDel merged 6 commits intomicrosoft:mainfrom Apr 9, 2021
Merged
Conversation
CaseyCarter
suggested changes
Mar 24, 2021
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
For the record, I'm ok with st/rd/th and Last. They're not localized, but then neither is the rest of this.
Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: statementreply <statementreply@gmail.com>
CaseyCarter
approved these changes
Mar 24, 2021
AnjuDel
approved these changes
Mar 25, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Apologies for the late review. I noticed one inconsistency in the display string (followed by a simplification). I haven't tested my suggested changes. I'm OK with proceeding to merge without addressing this feedback. However, if these changes are correct and you want to apply them, make sure to update the MSVC and VS PRs too.
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Apr 8, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts and questions
day?_lasttypes might be better without the "Last"s?is_negativeshould probably be dropped?